Fix incorrect log about not persisting duplicate state event. (#4776)

We were logging this when it was not true.
2026-08-27 22:34:55 +00:00 · 2019-03-01 16:47:12 +00:00
parent 1beebe916f
commit 3064952939
2 changed files with 5 additions and 3 deletions
@@ -0,0 +1 @@
+Fix incorrect log about not persisting duplicate state event.
@@ -436,10 +436,11 @@ class EventCreationHandler(object):

        if event.is_state():
            prev_state = yield self.deduplicate_state_event(event, context)
-            logger.info(
-                "Not bothering to persist duplicate state event %s", event.event_id,
-            )
            if prev_state is not None:
+                logger.info(
+                    "Not bothering to persist state event %s duplicated by %s",
+                    event.event_id, prev_state.event_id,
+                )
                defer.returnValue(prev_state)

        yield self.handle_new_client_event(
				`@@ -0,0 +1 @@`
				`Fix incorrect log about not persisting duplicate state event.`