Merge pull request #6148 from matrix-org/erikj/find_next_generated

Bound find_next_generated_user_id DB query.
2026-06-07 13:12:27 +00:00 · 2019-10-02 16:09:02 +01:00
parent 824df3ead4 de1823b521
commit 5d8ffdfe61
2 changed files with 4 additions and 1 deletions
@@ -0,0 +1 @@
+Improve performance of `find_next_generated_user_id` DB query.
@@ -493,7 +493,9 @@ class RegistrationWorkerStore(SQLBaseStore):
        """

        def _find_next_generated_user_id(txn):
-            txn.execute("SELECT name FROM users")
+            # We bound between '@1' and '@a' to avoid pulling the entire table
+            # out.
+            txn.execute("SELECT name FROM users WHERE '@1' <= name AND name < '@a'")

            regex = re.compile(r"^@(\d+):")
				`@@ -0,0 +1 @@`
				Improve performance of `find_next_generated_user_id` DB query.