dandri/synapse
1
0
Fork 0
mirror of https://github.com/element-hq/synapse.git synced 2026-03-30 17:15:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid inserting the same stream position multiple times

Browse Source
This commit is contained in:
Quentin Gliech
2026-02-09 09:52:30 +01:00
parent 826a7dd29a
commit 65780bcb34
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
synapse/storage/util/id_generators.py
View File

@@ -339,6 +339,10 @@ class MultiWriterIdGenerator(AbstractStreamIdGenerator):
# position with the current minimum.
self._current_positions[self._instance_name] = self._persisted_upto_position
# We remember the last inserted position so that we don't insert the same
# position twice, avoiding unnecessary writes.
self._last_inserted_stream_positions: int | None = None
def _load_current_ids(
self,
db_conn: LoggingDatabaseConnection,
@@ -840,7 +844,11 @@ class MultiWriterIdGenerator(AbstractStreamIdGenerator):
"""
pos = self.get_current_token_for_writer(self._instance_name)
txn.execute(sql, (self._stream_name, self._instance_name, pos))
with self._lock:
if self._last_inserted_stream_positions == pos:
return
txn.execute(sql, (self._stream_name, self._instance_name, pos))
self._last_inserted_stream_positions = pos
async def get_max_allocated_token(self) -> int:
return await self._db.runInteraction(