Fix error handling around when completing an AS transaction (#8693)

2026-08-29 07:48:20 +00:00 · 2020-10-30 16:50:48 +00:00
parent f27a789697
commit 7a0fd6f98d
2 changed files with 2 additions and 1 deletions
@@ -0,0 +1 @@
+Add more type hints to the application services code.
@@ -261,7 +261,7 @@ class ApplicationServiceTransactionWorkerStore(
            # has probably missed some events), so whine loudly but still continue,
            # since it shouldn't fail completion of the transaction.
            last_txn_id = self._get_last_txn(txn, service.id)
-            if (txn_id + 1) != txn_id:
+            if (last_txn_id + 1) != txn_id:
                logger.error(
                    "appservice: Completing a transaction which has an ID > 1 from "
                    "the last ID sent to this AS. We've either dropped events or "
				`@@ -0,0 +1 @@`
				`Add more type hints to the application services code.`