dandri/synapse
1
0
Fork 0
mirror of https://github.com/element-hq/synapse.git synced 2026-08-29 03:28:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add more context for why

Browse Source
This commit is contained in:
Eric Eastwood
2024-08-26 16:27:20 -05:00
parent 8bddbe23bd
commit a94c1dd62c
1 changed files with 16 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
synapse/storage/prepare_database.py
+16 -6
View File
@@ -589,8 +589,13 @@ def _clear_out_of_date_sliding_sync_tables(
`sliding_sync_joined_rooms`/`sliding_sync_membership_snapshots` tables.
This accounts for when someone downgrades their Synapse version and then upgrades it
again. This will ensure that we don't have any out-of-date data in the
`sliding_sync_joined_rooms`/`sliding_sync_membership_snapshots` tables.
again. This will ensure that we don't have any out-of-date/stale data in the
`sliding_sync_joined_rooms`/`sliding_sync_membership_snapshots` tables since any new
events sent in rooms would have also needed to be written to the sliding sync
tables. For example a new event needs to bump `event_stream_ordering` in
`sliding_sync_joined_rooms` table or some state in the room changing (like the room
name). Or another example of someone's membership changing in a room affecting
`sliding_sync_membership_snapshots`.
FIXME: This can be removed once we bump `SCHEMA_COMPAT_VERSION` and run the
foreground update for
@@ -609,8 +614,11 @@ def _clear_out_of_date_sliding_sync_joined_rooms_table(
Clears out-of-date entries from the `sliding_sync_joined_rooms` table.
This accounts for when someone downgrades their Synapse version and then upgrades it
again. This will ensure that we don't have any out-of-date data in the
`sliding_sync_joined_rooms` table.
again. This will ensure that we don't have any out-of-date/stale data in the
`sliding_sync_joined_rooms` table since any new events sent in rooms would have also
needed to be written to the `sliding_sync_joined_rooms` table or some state in the
room changing (like the room name). For example a new event needs to bump
`event_stream_ordering` in `sliding_sync_joined_rooms`.
FIXME: This can be removed once we bump `SCHEMA_COMPAT_VERSION` and run the
foreground update for
@@ -672,8 +680,10 @@ def _clear_out_of_date_sliding_sync_membership_snapshots_table(
Clears out-of-date entries from the `sliding_sync_membership_snapshots` table.
This accounts for when someone downgrades their Synapse version and then upgrades it
again. This will ensure that we don't have any out-of-date data in the
`sliding_sync_membership_snapshots` table.
again. This will ensure that we don't have any out-of-date/stale data in the
`sliding_sync_membership_snapshots` table since any new membership changes in rooms
would have also needed to be written to the `sliding_sync_membership_snapshots`
table.
FIXME: This can be removed once we bump `SCHEMA_COMPAT_VERSION` and run the
foreground update for