26298 Commits
Author SHA1 Message Date
bf32f4bd55 Implement MSC4536 query profiles endpoint (#20332)
This adds support for the profiles query endpoint defined in
[MSC4536](https://github.com/matrix-org/matrix-spec-proposals/pull/4536).

The endpoint filters out remote profiles as those are not yet stored
locally. There is also a hard limit of 100 profiles to fetch in one go.

### Pull Request Checklist

<!-- Please read
https://element-hq.github.io/synapse/latest/development/contributing_guide.html
before submitting your pull request -->

* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog
file](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#changelog).
The entry should:
- Be a short description of your change which makes sense to users.
"Fixed a bug that prevented receiving messages from other servers."
instead of "Moved X method from `EventStore` to `EventWorkerStore`.".
  - Use markdown where necessary, mostly for `code blocks`.
  - End with either a period (.) or an exclamation mark (!).
  - Start with a capital letter.
- Feel free to credit yourself, by adding a sentence "Contributed by
@github_username." or "Contributed by [Your Name]." to the end of the
entry.
* [x] [Code
style](https://element-hq.github.io/synapse/latest/code_style.html) is
correct (run the
[linters](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#run-the-linters))

---------

Co-authored-by: Olivier 'reivilibre <oliverw@matrix.org>
Co-authored-by: Olivier 'reivilibre <git.oo@emunest.net>
Co-authored-by: Eric Eastwood <madlittlemods@gmail.com>
Co-authored-by: Eric Eastwood <erice@element.io>
2026-11-16 16:08:18 +00:00
Erik Johnston 8e036ce956 Upgrade the preinstalled PostgreSQL client in the portdb CI job (#20522)
Fixes the portdb CI job. 

The portdb job fails since the `postgres:14` and `postgres:17` images
moved to the November minor releases. Those servers set a `pg_attver`
option on every column. An older `pg_dump` writes these out, and the
values differ between the two databases. The final diff in
test_synapse_port_db.sh is then never empty.

Newer versions of `pg_dump` skip these.

e.g. (from
https://github.com/element-hq/synapse/actions/runs/43429570465/job/131901164169):

```
-ALTER TABLE ONLY public.worker_read_write_locks_mode ALTER COLUMN lock_name SET (pg_attver=90372280);
-ALTER TABLE ONLY public.worker_read_write_locks_mode ALTER COLUMN lock_key SET (pg_attver=90372280);
-ALTER TABLE ONLY public.worker_read_write_locks_mode ALTER COLUMN write_lock SET (pg_attver=90372280);
-ALTER TABLE ONLY public.worker_read_write_locks_mode ALTER COLUMN token SET (pg_attver=90372280);
+ALTER TABLE ONLY public.worker_read_write_locks_mode ALTER COLUMN lock_name SET (pg_attver=81324360);
+ALTER TABLE ONLY public.worker_read_write_locks_mode ALTER COLUMN lock_key SET (pg_attver=81324360);
+ALTER TABLE ONLY public.worker_read_write_locks_mode ALTER COLUMN write_lock SET (pg_attver=81324360);
+ALTER TABLE ONLY public.worker_read_write_locks_mode ALTER COLUMN token SET (pg_attver=81324360);
```
2026-11-16 14:19:36 +00:00
dependabot[bot]andQuentin Gliech 25f3736fe8 Bump twisted from 26.4.0 to 26.10.0 (#20452)
Bumps [twisted](https://github.com/twisted/twisted) from 26.4.0 to
26.10.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/twisted/twisted/releases">twisted's
releases</a>.</em></p>
<blockquote>
<h2>Twisted 26.10.0rc1</h2>
<h1>twisted 26.10.0rc1 (2026-10-22)</h1>
<p>This is the last release with support for Python 3.10.</p>
<p>This include fixes for:</p>
<ul>
<li>CVE-2026-83813 (GHSA-jj36-9pvh-vj5r),</li>
<li>GHSA-vpp8-g58w-m8mp (no CVE assigned yet)</li>
<li>GHSA-cwm5-jh59-mwxr (no CVE assigned yet)</li>
<li>GHSA-3476-c5c2-fr73 (no CVE assigned yet)</li>
<li>GHSA-q7qq-6mhp-9rc4 (no CVE assigned yet)</li>
<li>GHSA-2qrf-pqgx-qh9v (no CVE assigned yet)</li>
<li>GHSA-53xc-49m8-p798 (no CVE assigned yet)</li>
</ul>
<h2>Features</h2>
<ul>
<li>It is now possible to set the SO_REUSEPORT and SO_REUSEADDR TCP
socket flags from user code. (<a
href="https://redirect.github.com/twisted/twisted/issues/9101">#9101</a>)</li>
<li>Python 3.14 is now supported. (<a
href="https://redirect.github.com/twisted/twisted/issues/12640">#12640</a>)</li>
<li><code>twisted.internet.defer.Deferred.__iter__</code>, used when
awaiting a <code>Deferred</code>, is now about 2-3% faster. (<a
href="https://redirect.github.com/twisted/twisted/issues/12727">#12727</a>)</li>
</ul>
<h2>Bugfixes</h2>
<ul>
<li>twisted.internet.tcp.Port.startListening() now closes the socket
when raising CannotListenError. (<a
href="https://redirect.github.com/twisted/twisted/issues/6108">#6108</a>)</li>
<li>Initiating a TCP connection with an address literals and a port
outside of the 1-65535 range in twisted.internet.tcp.BaseClient and
twisted.internet.iocpreactor.tcp.Client now triggers an errback instead
of an unhandled error. This change might also fix other unhandled errors
occurred while connecting using address literals. (<a
href="https://redirect.github.com/twisted/twisted/issues/7798">#7798</a>)</li>
<li>twisted.logger.LoggingFile.fileno now raises io.UnsupportedOperation
instead of returning -1.
This fixes an interoperability issue with multiprocessing. (<a
href="https://redirect.github.com/twisted/twisted/issues/9638">#9638</a>)</li>
<li><code>twistd</code> now exits with a non-zero status when given an
unknown subcommand. (<a
href="https://redirect.github.com/twisted/twisted/issues/12656">#12656</a>)</li>
<li>twisted.internet.testing.MemoryReactor.removeAll() now returns what
was removed to comply with IReactorFDSet.removeAll() (<a
href="https://redirect.github.com/twisted/twisted/issues/12743">#12743</a>)</li>
<li>twisted.internet.asyncioreactor.AsyncioSelectorReactor.callLater now
has the
same signature as twisted.internet.interfaces.IReactorTime.callLater.
twisted.internet.asyncioreactor.AsyncioSelectorReactor.callFromThread
now has the
same signature as
twisted.internet.interfaces.IReactorFromThreads.callFromThread. (<a
href="https://redirect.github.com/twisted/twisted/issues/12767">#12767</a>)</li>
<li>twisted.protocols.ftp.FTPClient now uses ip address of the original
ftp server to open passive data connections by default, instead of
trusting PASV responses. (<a
href="https://redirect.github.com/twisted/twisted/issues/12847">#12847</a>)</li>
</ul>
<h2>Improved Documentation</h2>
<ul>
<li>The “Writing Servers” and “UDP Networking” documentation pages have
been updated to remove obsolete references to persisting the reactor (a
feature gone from Twisted for several decades now), and to better
explain the factory and protocol setup and teardown lifecycle. (<a
href="https://redirect.github.com/twisted/twisted/issues/5031">#5031</a>)</li>
<li>Twisted's policy documentation now includes a prominently featured,
clear
explanation of our AI policy: to wit, including the outputs of
generative AI
systems is forbidden. (<a
href="https://redirect.github.com/twisted/twisted/issues/12676">#12676</a>)</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/twisted/twisted/blob/trunk/NEWS.rst">twisted's
changelog</a>.</em></p>
<blockquote>
<p>This file contains the release notes for Twisted.</p>
<p>It only contains high-level changes that are of interest to Twisted
library users.
Users of Twisted should check the notes before planning an upgrade.</p>
<p>Ticket numbers in this file can be looked up by visiting
<a
href="https://twisted.org/trac/ticket/">https://twisted.org/trac/ticket/</a><!--
raw HTML omitted --></p>
<p>.. towncrier release notes start</p>
<h1>twisted 26.10.0 (2026-10-30)</h1>
<p>No changes since 26.10.0rc2.
Since 26.10.0rc1, this release added the fix for <a
href="https://redirect.github.com/twisted/twisted/issues/12885">#12885</a>.</p>
<p>This is the last release with support for Python 3.10.</p>
<p>This include fixes for:</p>
<ul>
<li>CVE-2026-83813 (GHSA-jj36-9pvh-vj5r)</li>
<li>CVE-2023-44487 (GHSA-vpp8-g58w-m8mp)</li>
<li>CVE-2026-115778 (GHSA-cwm5-jh59-mwxr)</li>
<li>CVE-2026-115775 (GHSA-3476-c5c2-fr73)</li>
<li>CVE-2026-115877 (GHSA-q7qq-6mhp-9rc4)</li>
<li>CVE-2026-115774 (GHSA-2qrf-pqgx-qh9v)</li>
<li>CVE-2026-115776 (GHSA-53xc-49m8-p798)</li>
</ul>
<h2>Features</h2>
<ul>
<li>It is now possible to set the SO_REUSEPORT and SO_REUSEADDR TCP
socket flags from user code. (<a
href="https://redirect.github.com/twisted/twisted/issues/9101">#9101</a>)</li>
<li>Python 3.14 is now supported. (<a
href="https://redirect.github.com/twisted/twisted/issues/12640">#12640</a>)</li>
<li><code>twisted.internet.defer.Deferred.__iter__</code>, used when
awaiting a <code>Deferred</code>, is now about 2-3% faster. (<a
href="https://redirect.github.com/twisted/twisted/issues/12727">#12727</a>)</li>
</ul>
<h2>Bugfixes</h2>
<ul>
<li>twisted.internet.tcp.Port.startListening() now closes the socket
when raising CannotListenError. (<a
href="https://redirect.github.com/twisted/twisted/issues/6108">#6108</a>)</li>
<li>Initiating a TCP connection with an address literals and a port
outside of the 1-65535 range in twisted.internet.tcp.BaseClient and
twisted.internet.iocpreactor.tcp.Client now triggers an errback instead
of an unhandled error. This change might also fix other unhandled errors
occurred while connecting using address literals. (<a
href="https://redirect.github.com/twisted/twisted/issues/7798">#7798</a>)</li>
<li>twisted.logger.LoggingFile.fileno now raises io.UnsupportedOperation
instead of returning -1.
This fixes an interoperability issue with multiprocessing. (<a
href="https://redirect.github.com/twisted/twisted/issues/9638">#9638</a>)</li>
<li><code>twistd</code> now exits with a non-zero status when given an
unknown subcommand. (<a
href="https://redirect.github.com/twisted/twisted/issues/12656">#12656</a>)</li>
<li>twisted.internet.testing.MemoryReactor.removeAll() now returns what
was removed to comply with IReactorFDSet.removeAll() (<a
href="https://redirect.github.com/twisted/twisted/issues/12743">#12743</a>)</li>
<li>twisted.internet.asyncioreactor.AsyncioSelectorReactor.callLater now
has the
same signature as
twisted.internet.interfaces.IReactorTime.callLater.</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/twisted/twisted/commit/875d118c9a82a4f55a92ff399bd31f8928a52ad3"><code>875d118</code></a>
Manual changes for release notes.</li>
<li><a
href="https://github.com/twisted/twisted/commit/16efad17cac4e818b51c314c32b1a7eab1d27c70"><code>16efad1</code></a>
Run towncrier.</li>
<li><a
href="https://github.com/twisted/twisted/commit/a1392e7942973b9878ed91005eb92be80f1f4bce"><code>a1392e7</code></a>
Run incremental.</li>
<li><a
href="https://github.com/twisted/twisted/commit/44048df8c7581df6112016747bfe864e93ac0809"><code>44048df</code></a>
<a
href="https://redirect.github.com/twisted/twisted/issues/12705">#12705</a>
twisted.web HTTP/2: rate-limit stream resets to mitigate Rapid Reset
(...</li>
<li><a
href="https://github.com/twisted/twisted/commit/112e881bb31153bef085473947968fc05620fa9a"><code>112e881</code></a>
Merge branch 'trunk' into 12705-http2-rapid-reset</li>
<li><a
href="https://github.com/twisted/twisted/commit/1da20ef925594387c7faff9459794696a227ee1b"><code>1da20ef</code></a>
<a
href="https://redirect.github.com/twisted/twisted/issues/9101">#9101</a>:
add ability to enable SO_REUSEADDR and SO_REUSEPORT flags (<a
href="https://redirect.github.com/twisted/twisted/issues/12650">#12650</a>)</li>
<li><a
href="https://github.com/twisted/twisted/commit/36729d2c0cd47005d93c97fb759fe0c78fff3895"><code>36729d2</code></a>
Perform tuple conversion in _BaseTCPClient</li>
<li><a
href="https://github.com/twisted/twisted/commit/e8d1b9acd2eac3802f6193331792fc88dcc81b93"><code>e8d1b9a</code></a>
Simplify if statement</li>
<li><a
href="https://github.com/twisted/twisted/commit/26869f9f6a05fc1a10f826bf4fc5a7d581378495"><code>26869f9</code></a>
Merge branch 'trunk' into 9101.so_reuseaddr</li>
<li><a
href="https://github.com/twisted/twisted/commit/be48511c722548ddd4670f4070e7910a321e8a97"><code>be48511</code></a>
<a
href="https://redirect.github.com/twisted/twisted/issues/12875">#12875</a>
Update Python 3.15 in Github Actions + Upgrade Ubuntu for Codspeed
(#...</li>
<li>Additional commits viewable in <a
href="https://github.com/twisted/twisted/compare/twisted-26.4.0...twisted-26.10.0rc1">compare
view</a></li>
</ul>
</details>
<br />

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Quentin Gliech <quenting@element.io>
2026-11-16 11:17:42 +01:00
e5ac865661 Fix largest rooms Admin API failing when pg_stats has no common room IDs (#20390)
Fixes #19561

`GET /_synapse/admin/v1/statistics/database/rooms` returns a 500 when
`pg_stats` has no common `room_id` values for one of the tables it
checks. This happens in two cases:

- The table is empty or not yet analyzed, so `pg_stats` has no row for
it.
- No value is more common than the others, so `most_common_vals` is
`NULL`. `event_edges.room_id` hits this on servers where all rows were
written after schema 72 stopped filling the column.

The change skips the table in both cases, since it adds nothing to the
estimate.

Thanks to @christianarielli for finding the cause and suggesting the
fix. They're credited as co-author on the commit.

The new test runs only on Postgres, as the endpoint doesn't support
SQLite. It creates a room, runs `ANALYZE` while `event_push_actions` is
empty and `event_edges.room_id` is all `NULL`, and checks for a 200 with
the room listed. I ran it against Postgres 17.

`event_edges.room_id` isn't written any more, so dropping that table
from the list might make sense. I left that out to keep this PR small.

### Pull Request Checklist

<!-- Please read
https://element-hq.github.io/synapse/latest/development/contributing_guide.html
before submitting your pull request -->

* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog
file](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#changelog).
The entry should:
- Be a short description of your change which makes sense to users.
"Fixed a bug that prevented receiving messages from other servers."
instead of "Moved X method from `EventStore` to `EventWorkerStore`.".
  - Use markdown where necessary, mostly for `code blocks`.
  - End with either a period (.) or an exclamation mark (!).
  - Start with a capital letter.
- Feel free to credit yourself, by adding a sentence "Contributed by
@github_username." or "Contributed by [Your Name]." to the end of the
entry.
* [x] [Code
style](https://element-hq.github.io/synapse/latest/code_style.html) is
correct (run the
[linters](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#run-the-linters))

---------

Co-authored-by: Christian Arielli <903609+christianarielli@users.noreply.github.com>
Co-authored-by: Eric Eastwood <erice@element.io>
2026-11-13 13:57:50 +01:00
Erik Johnston 323a619544 Make trial unit tests use less memory (#20513)
This is something that came up during the Rust spike, where running lots
of unit tests in parallel used lots of memory.

This is primarily due to a) `HomeServer` object having circular
references during tests, and b) us not doing full GC all the time.

The fix is to ensure that we drop references to the `HomeServer` at the
end of each test (or only keep weakrefs around), so that the GC-0
collection we run at the end of each test correctly cleans it up.

Requires https://github.com/element-hq/synapse/pull/20512 to fully clean
everything up.
2026-11-13 10:09:38 +00:00
Erik Johnston 3bbbbf5d04 Run homeserver shutdown handlers at the end of each test (#20509)
This fixes the test `ThreadedMemoryReactorClock` to support
`removeSystemEventTrigger`, which in turn allows the shutdown triggers
to run when `HomeServer.shutdown()` is called in the tests. Previously,
`ThreadedMemoryReactorClock.removeSystemEventTrigger` raised a
`NotImplementedError`,

`cleanup_test_reactor_system_event_triggers` cleared the triggers by
hand so that a homeserver could be garbage collected. `shutdown()` now
removes them itself, so the helper goes.

We can also remove all the `tearDown` implementations that tried to
manually trigger the shutdown as its not longer necessary to do so
manually. They also didn't work, as they indexed `reactor.triggers` as
`[eventType][phase]` when the keys are `[phase][eventType]`
2026-11-13 10:09:16 +00:00
Erik Johnston 367f7fc52e Use better statistics for device_lists_changes_in_room in postgres (#20495)
The default statistics for `device_lists_changes_in_room` were often
wrong, underestimating the number of distinct values of `room_id` and
`stream_id` columns. This meant in Postgres 18 that it used the wrong
index, leading to large amounts of IO.

In Postgres 18 the query planner now supports "skip scans", which means
more of the indexes are available to be used, and thus makes it more
important to have accurate statistics.

The problematic query was operating on an array of room IDs and a range
of stream IDs. Previously, it would use the index on `(room_id,
stream_id)`. After upgrade, it started using `(stream_id, room_id)` on
the assumption that we were matching the majority of all rooms and thus
may as well pull out all rows matching the stream ID range.
2026-11-13 10:08:53 +00:00
Andrew Morgan c3e57a4e30 Note that the room_avatar_path config option isn't currently functional (#20490) 2026-11-13 10:04:59 +00:00
Johannes Marbach 7f832ceeed Avoid using apt-key in CI as it was removed in Ubuntu 26.04 (#20511)
This unbreaks the portdb jobs:

```
Run sudo sh -c 'echo "deb http://apt.postgresql.org/pub/repos/apt $(lsb_release -cs)-pgdg main" > /etc/apt/sources.list.d/pgdg.list'
  sudo sh -c 'echo "deb http://apt.postgresql.org/pub/repos/apt $(lsb_release -cs)-pgdg main" > /etc/apt/sources.list.d/pgdg.list'
  wget --quiet -O - https://www.postgresql.org/media/keys/ACCC4CF8.asc | sudo apt-key add -
  sudo apt-get update
  shell: /usr/bin/bash -e {0}
  env:
    RUST_VERSION: 1.87.0
    RUST_NIGHTLY_VERSION: nightly-2025-03-27
sudo: 'apt-key': command not found
Error: Process completed with exit code 1.
```
2026-11-12 11:10:11 +00:00
Kegan Dougal ce98985f9f Add check_room_id to more store functions which get events (#20436)
Use it when retrieving missing events in state DAG mode.

### Pull Request Checklist

<!-- Please read
https://element-hq.github.io/synapse/latest/development/contributing_guide.html
before submitting your pull request -->

* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog
file](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#changelog).
The entry should:
- Be a short description of your change which makes sense to users.
"Fixed a bug that prevented receiving messages from other servers."
instead of "Moved X method from `EventStore` to `EventWorkerStore`.".
  - Use markdown where necessary, mostly for `code blocks`.
  - End with either a period (.) or an exclamation mark (!).
  - Start with a capital letter.
- Feel free to credit yourself, by adding a sentence "Contributed by
@github_username." or "Contributed by [Your Name]." to the end of the
entry.
* [x] [Code
style](https://element-hq.github.io/synapse/latest/code_style.html) is
correct (run the
[linters](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#run-the-linters))
2026-11-11 08:19:03 +00:00
Ben Banfield-Zanin 7c1bf76bff Document that the MSC4143 transports endpoint can be run on a worker process (#20482)
Noticed whilst investigating
https://github.com/element-hq/synapse/pull/20425 to pull into ESS with
https://github.com/element-hq/ess-helm/pull/1770.

My reading of
https://github.com/element-hq/synapse/blob/v1.165.0rc1/synapse/rest/__init__.py#L187-L203
is that
https://github.com/element-hq/synapse/blob/v1.165.0rc1/synapse/rest/client/matrixrtc.py#L74-L78
and so both servlets will be available on worker processes.

I have tested the ESS PR and I have seen that the unstable endpoint is
happily returning 200 and data on a worker process.

### Pull Request Checklist

<!-- Please read
https://element-hq.github.io/synapse/latest/development/contributing_guide.html
before submitting your pull request -->

* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog
file](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#changelog).
The entry should:
- Be a short description of your change which makes sense to users.
"Fixed a bug that prevented receiving messages from other servers."
instead of "Moved X method from `EventStore` to `EventWorkerStore`.".
  - Use markdown where necessary, mostly for `code blocks`.
  - End with either a period (.) or an exclamation mark (!).
  - Start with a capital letter.
- Feel free to credit yourself, by adding a sentence "Contributed by
@github_username." or "Contributed by [Your Name]." to the end of the
entry.
* [x] [Code
style](https://element-hq.github.io/synapse/latest/code_style.html) is
correct (run the
[linters](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#run-the-linters))
2026-11-11 08:11:34 +00:00
Eric Eastwood 36553ccde2 Merge branch 'master' into develop 2026-11-10 14:14:49 -06:00
Eric Eastwood 7f6b880b84 Duplicate message about checking upgrade notes 2026-11-10 13:37:18 -06:00
Eric Eastwood 0adca7d1f7 1.165.0 v1.165.0 2026-11-10 13:28:59 -06:00
Ankit Jha 0744b28c6a Fix federated media downloads failing when a multipart response is split across chunks (#20282)
Fixes #20035

`_MultipartParserProtocol` assigned each `on_header_field` /
`on_header_value` / `on_part_data` value instead of accumulating it.
python-multipart calls these once per `dataReceived` chunk, so any
header name, header value or JSON part split across two chunks kept only
its last piece. A long `Location` in a federated media redirect was the
visible case: the truncated URL had no host and `get_file` failed with
`TypeError`.

The protocol now buffers header names, header values and the JSON part
in `bytearray`s and acts on them in `on_header_end` / `on_part_end`,
with a part counter replacing the `in_json` / `json_done` / `in_*`
flags. The file part still streams straight to the output stream, and
the existing `max_length` check still bounds everything that gets
buffered.

The new tests parse a file response and a redirect response split at
every byte offset, and byte by byte, and check the result matches the
unsplit parse. Before the fix, 100 and 115 split offsets respectively
produced a wrong result.

### Pull Request Checklist

<!-- Please read
https://element-hq.github.io/synapse/latest/development/contributing_guide.html
before submitting your pull request -->

* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog
file](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#changelog).
The entry should:
- Be a short description of your change which makes sense to users.
"Fixed a bug that prevented receiving messages from other servers."
instead of "Moved X method from `EventStore` to `EventWorkerStore`.".
  - Use markdown where necessary, mostly for `code blocks`.
  - End with either a period (.) or an exclamation mark (!).
  - Start with a capital letter.
- Feel free to credit yourself, by adding a sentence "Contributed by
@github_username." or "Contributed by [Your Name]." to the end of the
entry.
* [x] [Code
style](https://element-hq.github.io/synapse/latest/code_style.html) is
correct (run the
[linters](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#run-the-linters))

---------

Signed-off-by: Ankit Jha <ankit.jha@tradomate.one>
Signed-off-by: Ankit Jha <jhaankit373@gmail.com>
2026-11-10 16:42:13 +00:00
Ayesha Waseem 9d8354419c Report a user in device_lists.changed when they join after being invited (#20487)
`DeviceHandler.get_user_ids_changed`, which the sliding sync e2ee
extension and `GET /keys/changes` use, adds a member to
`newly_joined_or_invited_or_knocked_users` only when the previous
membership was none of join, invite or knock. A user going from invite
to join is skipped, so other members are never told to refresh the
devices of a user whose device list changed while they were only
invited. Classic sync does report them.

A change to join from any membership other than join is now counted.
join -> join (a profile change) is still ignored.
`test_extension_e2ee.py` covers invite -> join, invite -> join -> leave
in one window and a profile change, `test_keys.py` covers invite -> join
through `/keys/changes`. Not covered: device list changes made while a
user is only invited (#3504), which are still not announced until the
user joins.

Fixes #20486
2026-11-10 14:11:31 +00:00
Erik Johnston 4e43a3f710 Fix sync lazy-loaded membership cache to correctly handle concurrent requests (#20435)
Follows on from #20289 and #20433. Properly fixes handling of concurrent
requests (on single workers).

This tries to fix two cases:
1. We are *computing* responses for multiple syncs at the same time,
which currently causes the cache to get cross-contaminated.
2. Two syncs concurrent syncs on the wire (but don't overlap during
processing). When the second request is processed we correctly forget
any entries from the first request, however we currently still update
the cache with members returned on the second request. However, there is
no guarantee that the second request is what the client actually reads.

We use three rules to handle concurrent requests:
1. A response only uses cached members recorded at or before the
request's `since`. Members recorded after it cannot be from an ancestor
sync response.
2. Once a response has been built, we forget all already cached members
recorded after its `since`. This handles the client reusing an older
`since` token. Doing it at the end of the build rather than the start
also forgets members recorded by responses built at the same time.
3. We track the highest position seen for the device (`_newest`), from
the `since` of each request and the `next_batch` of each built response.
A response only records its members if its `next_batch` is after that
position. This handles responses that end at the same position, or that
finish out of order.

With these rules, when concurrent requests happen we throw away all
existing cached members and don't record any further members until one
sync has advanced sufficiently such that there are no longer any
concurrent sync requests.


Note that ideally we'd have some sort of per-connection identity so that
we can track this properly (like in sliding sync). However, that is a
bigger change. Instead, we note that we just need to detect concurrent
requests, and not update the cache in those cases.

Also note, can only detect concurrent requests that go to the same
worker.
2026-11-10 13:15:03 +00:00
Junker der Provinz 217e4c0f48 Fix RemoteHandler no longer sending logs after connecting (#20389)
Fixes #17480

Once `RemoteHandler` is connected, `whenConnected` returns a Deferred
that has already fired, so `writer` runs synchronously inside
`addCallbacks` and clears `_connection_waiter`. The next line then set
the waiter to that fired Deferred, so every later `_connect` call
returned early and logs stopped after the first line or two.

This sets the waiter before adding the callbacks, so a callback that
runs right away can still clear it. The new test logs a few more lines
over an existing connection and checks that they all arrive.

The bug came in with #9591, hence v1.30.0 in the changelog.

Thanks to @haarp for tracking this down and for the detailed
reproduction steps.

### Pull Request Checklist

<!-- Please read
https://element-hq.github.io/synapse/latest/development/contributing_guide.html
before submitting your pull request -->

* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog
file](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#changelog).
The entry should:
- Be a short description of your change which makes sense to users.
"Fixed a bug that prevented receiving messages from other servers."
instead of "Moved X method from `EventStore` to `EventWorkerStore`.".
  - Use markdown where necessary, mostly for `code blocks`.
  - End with either a period (.) or an exclamation mark (!).
  - Start with a capital letter.
- Feel free to credit yourself, by adding a sentence "Contributed by
@github_username." or "Contributed by [Your Name]." to the end of the
entry.
* [x] [Code
style](https://element-hq.github.io/synapse/latest/code_style.html) is
correct (run the
[linters](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#run-the-linters))
2026-11-09 18:43:57 +00:00
Quentin Gliech a7a665047e Rebuild the server TLS context in place on certificate reload (#20491)
`refresh_certificate` used to build a new `ServerContextFactory` on
every SIGHUP and then replace the factory on each listening port with a
fresh `TLSMemoryBIOFactory` wrapping the new one, reaching into the
port's `factory` attribute to do so.

Twisted asks the context factory for a context on every new connection,
so rebuilding the `SSL.Context` inside the existing factory is enough
for new connections to pick up the new certificate. `start()` now builds
the factory once, and `refresh_certificate` is only the SIGHUP handler.

This is spawning of #20452: Twisted 26.10 annotates `tcp.Port.factory`
as `Factory | None`, and mypy does not accept a `TLSMemoryBIOFactory`
there because its protocol type parameter does not match, so the old
assignment no longer type-checks. The change removes the assignment
rather than suppressing the error.

Verified with trial against Twisted 23.8.0 (our minimum declared dep),
26.4.0 (the current version in the lockfile) and 26.10.0 (the next
version), and with mypy against 26.4.0 and 26.10.0.
2026-11-09 18:37:09 +01:00
dependabot[bot] 179c674d6c Bump pyasn1 from 0.6.4 to 0.6.5 (#20462)
Bumps [pyasn1](https://github.com/pyasn1/pyasn1) from 0.6.4 to 0.6.5.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/pyasn1/pyasn1/releases">pyasn1's
releases</a>.</em></p>
<blockquote>
<h2>Release 0.6.5</h2>
<h2>Revision 0.6.5, released 26-10-2026</h2>
<ul>
<li>GHSA-mm57-4v3p-rchx: Decoded binary REAL mantissas in linear time
instead of repeatedly shifting a growing integer and slicing the
remaining bytes (thanks for reporting, manus-use, manus-pi, ucsurf,
adriank31)</li>
<li>GHSA-2qm8-x737-gmw5: Reassembled constructed BIT STRING fragments
in linear time while preserving their decoded bit values, including
intermediate fragment padding (thanks for reporting, manus-use)</li>
<li>GHSA-9m75-vc3g-4x39: Reassembled constructed OCTET STRING and
character-string fragments and indefinite-length ANY content in
linear time. Nested constructed OCTET STRING fragments now contribute
their decoded octets (thanks for reporting, alimony, manus-pi,
adriank31)</li>
<li>GHSA-fm9c-5rcf-2q5p: Bounded schemaless container type tracking
after two distinct tag sets to prevent quadratic CPU use from
colliding long tag IDs (thanks for reporting, droideck)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/pyasn1/pyasn1/blob/main/CHANGES.rst">pyasn1's
changelog</a>.</em></p>
<blockquote>
<h2>Revision 0.6.5, released 26-10-2026</h2>
<ul>
<li>GHSA-mm57-4v3p-rchx: Decoded binary REAL mantissas in linear time
instead of repeatedly shifting a growing integer and slicing the
remaining bytes (thanks for reporting, manus-use, manus-pi, ucsurf,
adriank31)</li>
<li>GHSA-2qm8-x737-gmw5: Reassembled constructed BIT STRING fragments
in linear time while preserving their decoded bit values, including
intermediate fragment padding (thanks for reporting, manus-use)</li>
<li>GHSA-9m75-vc3g-4x39: Reassembled constructed OCTET STRING and
character-string fragments and indefinite-length ANY content in
linear time. Nested constructed OCTET STRING fragments now contribute
their decoded octets (thanks for reporting, alimony, manus-pi,
adriank31)</li>
<li>GHSA-fm9c-5rcf-2q5p: Bounded schemaless container type tracking
after two distinct tag sets to prevent quadratic CPU use from
colliding long tag IDs (thanks for reporting, droideck)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/pyasn1/pyasn1/commit/5d1673657b729fb580467e2cf4875856bbca5e59"><code>5d16736</code></a>
Prepare release 0.6.5</li>
<li><a
href="https://github.com/pyasn1/pyasn1/commit/a36e3a3d067148d26197a6b7221fd0e2cde9cc86"><code>a36e3a3</code></a>
Fix quadratic CPU use in schemaless container decoding</li>
<li><a
href="https://github.com/pyasn1/pyasn1/commit/4ce00797c594b59c1fd6b86d9ebc3ba87b7ec9f9"><code>4ce0079</code></a>
Remove quadratic constructed OCTET STRING and ANY reassembly</li>
<li><a
href="https://github.com/pyasn1/pyasn1/commit/73ba7b043cc7e92cb37f16f2c955bff93b0e6f6c"><code>73ba7b0</code></a>
Remove quadratic constructed BIT STRING reassembly</li>
<li><a
href="https://github.com/pyasn1/pyasn1/commit/ce3ec3390784780a530047e0e77be5ff457636a4"><code>ce3ec33</code></a>
Remove quadratic binary REAL mantissa decoding</li>
<li>See full diff in <a
href="https://github.com/pyasn1/pyasn1/compare/v0.6.4...v0.6.5">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=pyasn1&package-manager=pip&previous-version=0.6.4&new-version=0.6.5)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the
[Security Alerts
page](https://github.com/element-hq/synapse/network/alerts).

</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-11-09 17:19:32 +00:00
Ayesha Waseem 4a8532b259 Fix logging breaking after a SIGHUP reload when stdio is redirected to the logs (#20402)
Reloading the log config on SIGHUP writes every record back into
Twisted's logging. `redirect_stdio_to_logs()` replaces `sys.stderr` with
a `LoggingFile` after startup, and `_load_logging_config` then rebuilds
`StreamHandler`s on it, so records hit the `logging during logging`
guard in `one_time_logging_setup` and JSON lines get wrapped a second
time.

`dictConfig` now runs with `sys.__stdout__` and `sys.__stderr__` swapped
in, and the redirected streams are put back afterwards, including when
the config is invalid. `tests/config/test_logger.py` covers both. Not
covered: Windows and configs that use a `FileHandler`.

Fixes #20091

### Pull Request Checklist

* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog
file](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#changelog).
* [x] [Code
style](https://element-hq.github.io/synapse/latest/code_style.html) is
correct (ruff check, ruff format and mypy run on the changed files)
2026-11-09 11:31:56 +00:00
Erik Johnston 20d925bb33 Add a metric for CPU time per thread type (#20405)
Adds a `synapse_thread_cpu_seconds_total{thread_type, mode}` metric,
grouping threads into:
1. the `main` thread
2. each registered threadpool (`threadpool_*`)
3. `tokio`
4. `other`

The kernel only reports CPU time for live threads, so the collector sums
per-thread deltas between scrapes. A thread that exits loses the CPU it
used since the last scrape.

This is primarily useful for seeing how busy the main thread is vs other
ones.
2026-11-09 10:30:04 +00:00
dependabot[bot] db537299bf Bump rustls from 0.23.45 to 0.23.46 (#20420) 2026-11-06 16:49:12 -06:00
Vladimir Babin c0d4a16a11 Clarify admin API docs for per-user ratelimit overrides (#20245)
Fixes #18885.

The "Override ratelimiting for users" section of the user admin API docs
described `messages_per_second` as "the number of actions that can be
performed in a second", which suggests the override applies to every
ratelimiter. In the code (`synapse/api/ratelimiting.py`) the override's
rate/burst values are only used by the event-sending ratelimiter
(`RequestRatelimiter.ratelimit`, i.e. `rc_message`); the generic
`Ratelimiter.can_do_action` only reads the override to check whether
`messages_per_second` is `0` and, if so, disables ratelimiting entirely
for that user.

Changes (docs only):
- State up front that the override replaces only the message-sending
limits (`rc_message`), not `rc_invites`/`rc_joins`/`rc_login` etc., and
that `messages_per_second = 0` disables all ratelimiting.
- Rename the sub-headings to "Get status of / Set / Delete ratelimit
**override**" and describe the fields as messages rather than actions.
- Explain that "Delete ratelimit override" restores the global config
limits rather than disabling ratelimiting.

The `#override-ratelimiting-for-users` anchor referenced elsewhere in
the page is unchanged.

Verified with `mdbook build` (mdbook 0.5.2, same as `docs-pr.yaml`):
renders cleanly, new anchors `#get-status-of-ratelimit-override`,
`#set-ratelimit-override`, `#delete-ratelimit-override` present.
2026-11-06 16:31:14 -06:00
Matt Van HornandMatt Van Horn 4787b424e9 Accept notary queries without minimum validity timestamps (#20477)
### Pull Request Checklist

A notary key query that leaves out minimum_valid_until_ts is rejected
with errcode M_MISSING_PARAM and an error naming that field as required.
Callers that follow the server-server API, where the timestamp is
optional and the server is supposed to use the current time, cannot
complete the query. The criteria model typed minimum_valid_until_ts as
an integer or null but gave it no default, so validation treated the
field as required and failed before the query ran.

An explicit null was already a separate accepted value, used for
half-lifetime cache behaviour, and was not the same as omitting the
field.

The field now defaults to null, so an omitted timestamp validates. After
parsing, each key whose criteria did not include the field is replaced
with a copy that sets minimum_valid_until_ts to the current time in
milliseconds. Explicit null is left unchanged, and an empty key-id map
is left unchanged so a request for every cached key still ignores
validity. Tests cover the omitted timestamp against cache lifetime,
mixed criteria including zero and null, non-integer timestamps, and a
body without server_keys, and a bugfix newsfragment records the default.

Ran `python3 -m pytest -q tests/rest/key/v2/test_remote_key_resource.py`
in a Linux container (`python:3.12`) for the synapse RemoteKey change; 7
tests passed.
The tests in `tests/rest/key/v2/test_remote_key_resource.py` fail
without the fix in the synapse RemoteKey change (checked by reverting
the source changes).

Fixes #20466

---------

Co-authored-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
2026-11-05 23:11:57 +00:00
Will Hunt 72a27d71db Allow MSC4155 to work if m.invite_permission_config was previously set (#20476)
Allow MSC4155 to work if m.invite_permission_config was previously set

Fixes #20474
2026-11-05 15:11:10 +00:00
Hugh Nimmo-Smith 8e1e7dc0af Rate limiting, configurable TTL and correct auth responses for MSC4388 (sign-in with QR code) (#20404)
This PR should be reviewable on a commit-by-commit basis. If you would
prefer that it is broken down into multiple PRs then I can do so.

Fixes to match latest MSC4388:

- Return `200` with `create_available=false` for `GET` when configured
in `authenticated` mode and no access token presented
- Return `401` for a `GET` where an invalid/expired token is presented
- Return `404` for `DELETE` where session has expired but not yet
evicted

Features:

- Rate limiting which is configurable via
`experimental_features.msc4388_rc_create` (for `POST` and is per
requester for authenticated requests or per client IP for
unauthenticated requests) and
`experimental_features.msc4388_rc_requests` (for `GET`/`PUT`/`DELETE`).
- Allow the session TTL to be configured via the
`experimental_features.msc4388_session_ttl`. As per spec this is between
2 and 5 minutes.
- Concurrent sessions are unlimited for authenticated requesters
(subject to the rate limits).
- Unauthenticated requesters have a maximum concurrent sessions limit
(default 1,000) which is configurable by
`experimental_features.msc4388_max_unauthenticated_sessions`.

Misc:

- Code and comment cleanup

The experimental feature is tracked by
https://github.com/element-hq/synapse/issues/19433 and I will update it
with the new config options when this PR merges.
2026-11-05 15:00:12 +00:00
Will Hunt 77bff3dbd9 Add "ESS" to BUG_REPORT.yml template (#20475)
Because I suspect this is probably a useful thing to know.

### Pull Request Checklist

<!-- Please read
https://element-hq.github.io/synapse/latest/development/contributing_guide.html
before submitting your pull request -->

* [ ] Pull request is based on the develop branch
* [ ] Pull request includes a [changelog
file](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#changelog).
The entry should:
- Be a short description of your change which makes sense to users.
"Fixed a bug that prevented receiving messages from other servers."
instead of "Moved X method from `EventStore` to `EventWorkerStore`.".
  - Use markdown where necessary, mostly for `code blocks`.
  - End with either a period (.) or an exclamation mark (!).
  - Start with a capital letter.
- Feel free to credit yourself, by adding a sentence "Contributed by
@github_username." or "Contributed by [Your Name]." to the end of the
entry.
* [ ] [Code
style](https://element-hq.github.io/synapse/latest/code_style.html) is
correct (run the
[linters](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#run-the-linters))
2026-11-05 11:18:40 +00:00
Sid Karunaratne 86c96382b2 Fix store_into_file leaving empty files behind when media downloads fail (#20429)
Fix a bug introduced in Synapse v1.146.0 where failed remote media
downloads and URL previews would leave behind empty files in the media
store.

Regressed in #19204 which restructured
`MediaStorage.store_into_file(...)` to support running without a local
media store. As part of that, the `yield` (where the caller writes into
the file) was moved outside of the `try`/`except` that cleans up the
file on failure. Since `store_into_file(...)` is an
`asynccontextmanager`, an exception raised by the caller is thrown back
in at the `yield`, so it now bypasses the cleanup entirely.

This means any failed remote media download leaves a zero-byte file in
`remote_content/` (and similarly `url_cache/` for URL previews) without
a corresponding database row. Most of these fail before a single byte is
written, for example `NotRetryingDestination` while a remote server is
backed off, which fails instantly without any network request. Media
retention works from the database so it never cleans these up, and
because each attempt uses a fresh `filesystem_id`, clients repeatedly
requesting media (e.g. avatars of members on dead servers) keep
accumulating new ones. On a small homeserver, this added up to ~6000
orphaned files (and ~36000 directories) since upgrading to v1.146.0.

This PR moves the `yield` back inside the `try` (as it was before
#19204) so the file is removed again on failure. This applies to both
the local media store and the temporary file used when
`enable_local_media_storage` is disabled.


### Dev notes

To find orphaned files on an affected homeserver (zero-byte files with
no matching `remote_media_cache` row):

```shell
find /path/to/media_store/remote_content /path/to/media_store/url_cache -type f -size 0
```

Any of these without a matching row in `remote_media_cache` (or
`local_media_repository` for `url_cache/`) are orphans and safe to
delete, along with any empty directories left behind.
2026-11-05 11:06:23 +00:00
Eric Eastwood e3b6b231f6 Fix version used in upgrade note v1.165.0rc1 2026-11-04 15:01:05 -06:00
Eric Eastwood eeeaa20e6a Better flow for upgrade note 2026-11-04 14:58:35 -06:00
Eric Eastwood 6cc064d011 Same number of blank lines (4) 2026-11-04 14:57:25 -06:00
Eric Eastwood 6329040881 Better changelog entry 2026-11-04 14:56:17 -06:00
Eric Eastwood 0b1b12e6d7 Restore #20397 2026-11-04 14:51:56 -06:00
Eric Eastwood 0c5f95b8ed Easier to follow wording 2026-11-04 14:46:23 -06:00
Eric Eastwood 37ddbe954b Explain what changed in the MSC4388 implementation 2026-11-04 14:44:33 -06:00
Eric Eastwood 424421559d Fix GitHub link 2026-11-04 14:41:33 -06:00
Eric Eastwood bd8662be03 Combine server announcement items 2026-11-04 14:40:57 -06:00
Eric Eastwood 55ec151c16 Point to upgrade notes 2026-11-04 14:38:51 -06:00
Eric Eastwood 76b31ad6c1 Move upgrade notes to correct release
(PR took a little while to merge)
2026-11-04 14:36:17 -06:00
Eric Eastwood 1e3529d8cc Remove change that already was backported/shipped in `1.164.1 2026-11-04 14:30:33 -06:00
Eric Eastwood f2d0563e82 Remove another change that already was backported/shipped 2026-11-04 14:29:48 -06:00
Eric Eastwood 8aa96d627b Remove fixes already backported/shipped in prior releases 2026-11-04 14:28:09 -06:00
Eric Eastwood 560da50b43 Remove whitespace that messes with the whole list spacing 2026-11-04 14:22:41 -06:00
Eric Eastwood 678abe961c Link MSC4480 2026-11-04 14:21:45 -06:00
Eric Eastwood 2a20394aa3 Link MSC4508 2026-11-04 14:19:58 -06:00
Eric Eastwood 3e198cd051 1.165.0rc1 2026-11-04 14:18:37 -06:00
Ayesha Waseem 44757a4917 Prefer the stored server key valid for longest when several notaries answered (#20406)
`KeyStore.get_server_keys_json` orders the `server_keys_json` rows of a
key by `ts_added_ms` and each row overwrites the previous one, so the
last notary to answer wins even when its `ts_valid_until_ms` is lower
than an earlier answer's. When that answer is stale, `StoreKeyFetcher`
returns a key below `minimum_valid_until_ts` and event signature
verification fails although a long enough key is stored.

The query now orders by `ts_valid_until_ms, ts_added_ms`, so the
longest-valid entry wins and the most recent one still wins a tie.
`tests/crypto/test_keyring.py` stores two notary responses for one key,
the longer-lived one first, and checks that the lookup and
`verify_json_for_server` use it. Not covered:
`get_server_keys_json_for_remote` and
`get_all_server_keys_json_for_remote`, which still prefer the most
recently added row.

Fixes #20358

### Pull Request Checklist

* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog
file](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#changelog).
* [x] [Code
style](https://element-hq.github.io/synapse/latest/code_style.html) is
correct (ruff check, ruff format and mypy run on the changed files)
2026-11-04 19:36:40 +00:00
45175f2247 [Server Announcements] Admin API to send announcements and list the rooms (#20467)
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-04 18:33:10 +00:00
2e81f0785a Handle read receipts in Server Announcement rooms (#20427)
Co-authored-by: Quentin Gliech <quenting@element.io>
Co-authored-by: Andrew Morgan <andrew@amorgan.xyz>
2026-11-04 18:32:44 +00:00