ee733ae2f6
Correctly handle room_id/state_key being null
...
These should either be absent or strings. We cannot use `Option` as that
does not differentiate between `null` and an absent field.
2026-05-27 15:51:03 +01:00
a427fb3fe2
Expand clone_event docstring
2026-05-27 13:44:12 +01:00
8fd10e4143
s/test_room_id_for_create_event/test_room_id_for_create_event_format_v4/
2026-05-27 13:38:25 +01:00
ae3a03fc4f
Sanity check state_key is None instead of some empty string
2026-05-27 13:37:22 +01:00
9fa851d7f5
Comment on why state_key_attr
2026-05-27 13:31:59 +01:00
141df2ed8b
Comment on why we're using a Mock
2026-05-27 13:28:28 +01:00
90ee916529
Comment on type ignore
2026-05-27 13:23:38 +01:00
da42b90fa1
Add back isinstance EventProtocol test
2026-05-27 13:20:10 +01:00
feaa364f86
Rename bad_key to unknown_key
2026-05-27 13:14:57 +01:00
d6258ff227
Make test_redact_missing_type clearer
2026-05-27 13:13:42 +01:00
925f5a1294
Handle MSC4242 in redact
2026-05-27 12:57:30 +01:00
15462d1d44
Lint
2026-05-27 12:57:16 +01:00
f1ae164ab9
Remove redacted_because TODO
2026-05-27 12:53:46 +01:00
51ace0f588
Don't check PDU size in compute_reference_hash
2026-05-27 12:52:45 +01:00
1479a94ee7
Pop AGE_TS when redacting as well
2026-05-27 12:47:45 +01:00
ecf8e8c869
Comment why type_
2026-05-27 12:05:15 +01:00
309f826d21
Note that third-party modules rely on deprecated functions
2026-05-27 12:04:04 +01:00
ee669251c1
Clean up .sticky_duration()
2026-05-27 12:02:50 +01:00
ffe6c8b430
Add MSC4354_STICKY constant
2026-05-27 11:51:03 +01:00
17b231c3e8
Fix RoomPolicyTestCase to not set signature block
2026-05-27 11:35:11 +01:00
7d5f36d2a4
Merge remote-tracking branch 'origin/develop' into erikj/events_rust
2026-05-27 11:22:59 +01:00
1d7f67f91b
Change new test_validate_new_with_mentions_succeeds_even_when_frozen test
...
Since we no longer have an `event.freeze()` we simply test that the
validator works on the (already frozen) event.
Test was introduced in #19634
2026-05-27 11:16:06 +01:00
0e39c0c8f6
Fix policy server signature merging again ( #19797 )
...
Fixes #19796
2026-05-26 14:12:20 -05:00
2d866f945f
Merge remote-tracking branch 'origin/develop' into erikj/events_rust
2026-05-21 15:04:37 +01:00
025f1a479e
Fix tests
2026-05-21 14:56:48 +01:00
c9e9d76e86
Make MAX_DURATION a SynapseDuration
2026-05-21 14:45:52 +01:00
b99fd7329d
s/debug_assert/ensure
2026-05-21 14:37:30 +01:00
1bbb0332bd
Drop SimpleAuthPrevEvents
2026-05-21 14:36:19 +01:00
894d223132
Mention where get_templated_pdu_json is used
2026-05-21 14:34:55 +01:00
aae2de1cf0
Update get_dict docstring
2026-05-21 14:32:11 +01:00
24e7f8516a
Rename to parsed_event
2026-05-21 14:31:26 +01:00
fc65b1d5bc
Add room version to error
2026-05-21 14:27:14 +01:00
27e312ddaf
Make JsonObject.object private
2026-05-21 14:26:02 +01:00
8e6e29cf1a
Fix MAX_PDU_SIZE_BYTES
2026-05-21 14:15:02 +01:00
e82ebe17b2
Small refactor to ensure we call 'validate' for all formats
2026-05-21 14:14:29 +01:00
69c8d226b8
Ensure we don't have stray auth_events or event_id fields unexpectedly set
2026-05-21 14:10:51 +01:00
71151640b2
Update error for auth_event_ids
2026-05-21 14:02:10 +01:00
f5f7e7c729
Convert get_room_id_for_optional_room_id into match
2026-05-21 13:56:08 +01:00
d4801f78a7
Docstring for type_state_key_tuple
2026-05-21 13:46:10 +01:00
d7a8dc5e27
Comment which fields are mutable and immutable
2026-05-21 13:43:59 +01:00
cdc09df65a
s/on-the-wire/over-the-wire
2026-05-21 13:38:53 +01:00
4655b435ee
Follow #19468 (Fix sending heroes in Sliding Sync) with small tweaks ( #19791 )
...
Follows: #19468
The main change is from this comment
https://github.com/element-hq/synapse/pull/19468#discussion_r2810364196
I am pretty sure it's safe and was tempted to add it to that PR, but for
easier bisection and reversion in case it goes wrong, thought a separate
commit would be the best.
The other drive-by change is a boolean logic simplification
Simplify condition (boolean equivalence)
Don't fetch name state from `meta_room_state` since it's no longer used
there
---------
Signed-off-by: Olivier 'reivilibre <oliverw@matrix.org >
2026-05-20 16:58:39 +01:00
57299fd5bd
Bump lxml from 6.0.2 to 6.1.0 ( #19716 )
...
Signed-off-by: dependabot[bot] <support@github.com >
2026-05-20 13:32:08 +00:00
966e193e4e
Fix sending heroes in SSS when m.room.name="" ( #19468 )
...
As per the spec, a room with m.room.name value that is absent, null or
empty should be treated as if there is no m.room.name event at all:
https://spec.matrix.org/v1.17/client-server-api/#mroomname
This fetches the full m.room.name event and checks the content.name
instead of only checking the existence of the m.room.name event. This
results in correctly sending heroes for those rooms.
Fixes: https://github.com/element-hq/synapse/issues/19447
Signed-off-by: Joe Groocock <me@frebib.net >
2026-05-20 12:10:54 +01:00
be03be7b50
Partially revert "Bump attrs from 25.4.0 to 26.1.0 ( #19684 )" ( #19789 )
...
Accidental bump broke build for Fedora and RHEL.
This reverts commit 2e9d6f7f35https://matrix.to/#/!rh9Uxk45AsPongyP3ypgpsCmuIufiggD6mDXFWh4_FM/$0mdulZEyJFdI6bwS8GFwYnFt-zmpyCyx2DwcA8JyuY8?via=jki.re&via=matrix.org&via=element.io )
room (private)
2026-05-20 11:47:43 +01:00
87095ae500
fix: invalidate access token cache on device deletion ( #19483 )
...
when an access token had a refresh token associated to it in the
database, deleting this refresh token (for example when deleting the
device using it) would cascade delete the access token, which wouldn't
be returned by the sql query that was supposed to delete it on its own,
and an empty array was passed to the cache invalidation function.
2026-05-20 11:06:16 +01:00
f83e8c34c5
Merge branch 'master' into develop
2026-05-19 14:34:40 +01:00
7b1c4da5df
1.153.0
2026-05-19 14:13:03 +01:00
ec4950b438
Bump types-jsonschema from 4.26.0.20260202 to 4.26.0.20260508 ( #19683 )
...
Signed-off-by: dependabot[bot] <support@github.com >
2026-05-18 16:10:40 +00:00
4d0e4ff935
Fix /sync failing when MSC4354 Sticky Events are enabled and the sync request filters out Ephemeral Data Units (EDUs). ( #19787 )
...
Fixes : #19779
Fixes: https://github.com/element-hq/synapse/issues/19618
See also: #19786 (which would have caught this, but currently has too
many findings to enable)
Fix UnboundLocalError when MSC4354 is enabled in sync and all EDUs are
filtered out
---------
Signed-off-by: Olivier 'reivilibre <oliverw@matrix.org >
2026-05-18 12:15:57 +01:00
Erik Johnston