mirror of
https://github.com/element-hq/synapse.git
synced 2026-07-28 18:40:17 +00:00
Erik JohnstonandGitHub
51672809c7
The cache key of `_get_server_keys_json` is a single argument which is
itself a `(server_name, key_id)` tuple, and `store_server_keys_response`
passed that nested tuple straight into the cache invalidation stream.
psycopg2 quietly serialises the inner tuple as a Postgres *record*, so
the `keys` column of `cache_invalidation_stream_by_instance` ended up
holding the record literal as a single string (e.g.
`{"(srv,ed25519:abc)"}`) — which never matches the real cache key on the
receiving side, i.e. the
invalidation has always been a silent no-op on workers. The native Rust
backend's stricter parameter conversion turns the same nested tuple into
a loud `TypeError: unsupported parameter type for postgres: tuple`.
Fix it the same way https://github.com/element-hq/synapse/pull/18899 did
for `_get_e2e_cross_signing_signatures_for_device`, which has the same
nested-tuple key shape: invalidate the local cache directly, JSON-encode
the key for the replication row, and decode it again in
`process_replication_rows`.
Found as part of the the effort to port the database pool to Rust.
176 lines
6.3 KiB
Python
176 lines
6.3 KiB
Python
#
|
|
# This file is licensed under the Affero General Public License (AGPL) version 3.
|
|
#
|
|
# Copyright 2023 The Matrix.org Foundation C.I.C.
|
|
# Copyright (C) 2023 New Vector, Ltd
|
|
#
|
|
# This program is free software: you can redistribute it and/or modify
|
|
# it under the terms of the GNU Affero General Public License as
|
|
# published by the Free Software Foundation, either version 3 of the
|
|
# License, or (at your option) any later version.
|
|
#
|
|
# See the GNU Affero General Public License for more details:
|
|
# <https://www.gnu.org/licenses/agpl-3.0.html>.
|
|
#
|
|
# Originally licensed under the Apache License, Version 2.0:
|
|
# <http://www.apache.org/licenses/LICENSE-2.0>.
|
|
#
|
|
# [This file includes modifications made by New Vector Limited]
|
|
#
|
|
#
|
|
from unittest.mock import Mock, call
|
|
|
|
from signedjson.key import generate_signing_key, get_verify_key
|
|
|
|
from synapse.storage.database import LoggingTransaction
|
|
from synapse.storage.keys import FetchKeyResult
|
|
|
|
from tests.replication._base import BaseMultiWorkerStreamTestCase
|
|
from tests.unittest import HomeserverTestCase
|
|
|
|
|
|
class CacheInvalidationTestCase(HomeserverTestCase):
|
|
def setUp(self) -> None:
|
|
super().setUp()
|
|
self.store = self.hs.get_datastores().main
|
|
|
|
def test_bulk_invalidation(self) -> None:
|
|
master_invalidate = Mock()
|
|
|
|
self.store._get_cached_user_device.invalidate = master_invalidate
|
|
|
|
keys_to_invalidate = [
|
|
("a", "b"),
|
|
("c", "d"),
|
|
("e", "f"),
|
|
("g", "h"),
|
|
]
|
|
|
|
def test_txn(txn: LoggingTransaction) -> None:
|
|
self.store._invalidate_cache_and_stream_bulk(
|
|
txn,
|
|
# This is an arbitrarily chosen cached store function. It was chosen
|
|
# because it takes more than one argument. We'll use this later to
|
|
# check that the invalidation was actioned over replication.
|
|
cache_func=self.store._get_cached_user_device,
|
|
key_tuples=keys_to_invalidate,
|
|
)
|
|
|
|
self.get_success(
|
|
self.store.db_pool.runInteraction(
|
|
"test_invalidate_cache_and_stream_bulk", test_txn
|
|
)
|
|
)
|
|
|
|
master_invalidate.assert_has_calls(
|
|
[call(key_list) for key_list in keys_to_invalidate],
|
|
any_order=True,
|
|
)
|
|
|
|
|
|
class CacheInvalidationOverReplicationTestCase(BaseMultiWorkerStreamTestCase):
|
|
def setUp(self) -> None:
|
|
super().setUp()
|
|
self.store = self.hs.get_datastores().main
|
|
|
|
def test_bulk_invalidation_replicates(self) -> None:
|
|
"""Like test_bulk_invalidation, but also checks the invalidations replicate."""
|
|
master_invalidate = Mock()
|
|
worker_invalidate = Mock()
|
|
|
|
self.store._get_cached_user_device.invalidate = master_invalidate
|
|
worker = self.make_worker_hs("synapse.app.generic_worker")
|
|
worker_ds = worker.get_datastores().main
|
|
worker_ds._get_cached_user_device.invalidate = worker_invalidate
|
|
|
|
keys_to_invalidate = [
|
|
("a", "b"),
|
|
("c", "d"),
|
|
("e", "f"),
|
|
("g", "h"),
|
|
]
|
|
|
|
def test_txn(txn: LoggingTransaction) -> None:
|
|
self.store._invalidate_cache_and_stream_bulk(
|
|
txn,
|
|
# This is an arbitrarily chosen cached store function. It was chosen
|
|
# because it takes more than one argument. We'll use this later to
|
|
# check that the invalidation was actioned over replication.
|
|
cache_func=self.store._get_cached_user_device,
|
|
key_tuples=keys_to_invalidate,
|
|
)
|
|
|
|
assert self.store._cache_id_gen is not None
|
|
initial_token = self.store._cache_id_gen.get_current_token()
|
|
self.get_success(
|
|
self.database_pool.runInteraction(
|
|
"test_invalidate_cache_and_stream_bulk", test_txn
|
|
)
|
|
)
|
|
second_token = self.store._cache_id_gen.get_current_token()
|
|
|
|
self.assertGreaterEqual(second_token, initial_token + len(keys_to_invalidate))
|
|
|
|
self.get_success(
|
|
worker.get_replication_data_handler().wait_for_stream_position(
|
|
"master", "caches", second_token
|
|
)
|
|
)
|
|
|
|
master_invalidate.assert_has_calls(
|
|
[call(key_list) for key_list in keys_to_invalidate],
|
|
any_order=True,
|
|
)
|
|
worker_invalidate.assert_has_calls(
|
|
[call(key_list) for key_list in keys_to_invalidate],
|
|
any_order=True,
|
|
)
|
|
|
|
def test_server_keys_json_invalidation_replicates(self) -> None:
|
|
"""`_get_server_keys_json` takes a single argument which is itself a
|
|
tuple, and we can't send nested keys over replication: the keys are
|
|
JSON-encoded on the sending side and decoded again in
|
|
`process_replication_rows`. Check the round trip invalidates the right
|
|
cache entry on the worker.
|
|
"""
|
|
master_invalidate = Mock()
|
|
worker_invalidate = Mock()
|
|
|
|
self.store._get_server_keys_json.invalidate = master_invalidate
|
|
worker = self.make_worker_hs("synapse.app.generic_worker")
|
|
worker_ds = worker.get_datastores().main
|
|
worker_ds._get_server_keys_json.invalidate = worker_invalidate
|
|
|
|
signing_key = generate_signing_key("ver1")
|
|
verify_key = get_verify_key(signing_key)
|
|
key_id = f"{verify_key.alg}:{verify_key.version}"
|
|
|
|
assert self.store._cache_id_gen is not None
|
|
initial_token = self.store._cache_id_gen.get_current_token()
|
|
|
|
self.get_success(
|
|
self.store.store_server_keys_response(
|
|
"server1",
|
|
from_server="server2",
|
|
ts_added_ms=self.clock.time_msec(),
|
|
verify_keys={
|
|
key_id: FetchKeyResult(
|
|
verify_key=verify_key, valid_until_ts=200_000
|
|
),
|
|
},
|
|
response_json={},
|
|
)
|
|
)
|
|
second_token = self.store._cache_id_gen.get_current_token()
|
|
self.assertGreater(second_token, initial_token)
|
|
|
|
self.get_success(
|
|
worker.get_replication_data_handler().wait_for_stream_position(
|
|
"master", "caches", second_token
|
|
)
|
|
)
|
|
|
|
expected_key = (("server1", key_id),)
|
|
master_invalidate.assert_called_once_with(expected_key)
|
|
worker_invalidate.assert_called_once_with(expected_key)
|