dandri/wadamesh
1
0
Fork 0
mirror of https://github.com/ALLFATHER-BV/wadamesh.git synced 2026-10-15 23:30:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(storage): commit rooted preference updates

Browse Source 
Signed-off-by: Pixel Perfect <me@pixp.cc>
This commit is contained in:
Pixel Perfect
2026-08-01 20:33:04 -07:00
parent a68ea66805
commit 603217312e
1 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/DataStore.cpp
+11 -2
View File
@@ -426,8 +426,17 @@ bool DataStore::savePrefs(const NodePrefs& _prefs, double node_lat, double node_
_fs->remove(_rp("/new_prefs.tmp")); // short write (storage full?) — keep the old main file
return false;
}
_fs->remove(_rp("/new_prefs"));
return _fs->rename(_rp("/new_prefs.tmp"), _rp("/new_prefs"));
// _rp() returns a pointer to one shared scratch buffer when the store has
// a root prefix (for example SD:/meshcomod). Calling it twice in rename()
// therefore aliases both arguments to whichever path was formatted last,
// leaving new_prefs.tmp stranded even though the data itself was written.
// Keep the source and destination in independent buffers for the swap.
char tmp_path[48];
char live_path[48];
snprintf(tmp_path, sizeof(tmp_path), "%s/new_prefs.tmp", _root);
snprintf(live_path, sizeof(live_path), "%s/new_prefs", _root);
_fs->remove(live_path);
return _fs->rename(tmp_path, live_path);
}
return false;
}