dandri/zigbee2mqtt
1
0
Fork 0
mirror of https://github.com/Koenkk/zigbee2mqtt.git synced 2026-08-27 21:20:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Skip configure when device does not require it. https://github.com/Koenkk/zigbee2mqtt/issues/2588

Browse Source
This commit is contained in:
Koen Kanters
2019-12-23 20:48:37 +01:00
parent 9db1467ed8
commit e63d196966
2 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/extension/deviceConfigure.js
+5
View File
@@ -48,6 +48,11 @@ class DeviceConfigure extends BaseExtension {
}
const mappedDevice = zigbeeHerdsmanConverters.findByZigbeeModel(entity.device.modelID);
if (!mappedDevice.configure) {
logger.warn(`Skipping configure of '${entity.name}', device does not require this.`);
return;
}
this.configure(entity.device, mappedDevice, entity.settings, true);
}
test/deviceConfigure.test.js
+6
View File
@@ -105,6 +105,12 @@ describe('Device configure', () => {
expect(logger.error).toHaveBeenCalledWith(`Device 'remote_random_non_existing' does not exist`);
});
it('Should skip reconfigure when device does not require this', async () => {
await MQTT.events.message('zigbee2mqtt/bridge/configure', 'bulb');
await flushPromises();
expect(logger.warn).toHaveBeenCalledWith(`Skipping configure of 'bulb', device does not require this.`)
});
it('Should not configure when interviewing', async () => {
const device = zigbeeHerdsman.devices.remote;
delete device.meta.configured;