dandri/livekit
1
0
Fork 0
mirror of https://github.com/livekit/livekit.git synced 2026-09-01 20:09:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Create NACK tracker only once. (#4527)

Browse Source 
Not a major issue, but just avoiding duplicate creation of NACK module.
RTCP feedback of `nack` and `nack pli` end up getting treated as `nack`
and was double creating.
This commit is contained in:
Raja Subramanian
2026-05-15 12:45:51 +05:30
committed by GitHub
parent 89faaeba82
commit 4a7b1e8587
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/sfu/buffer/buffer_base.go
+3 -1
View File
@@ -387,7 +387,9 @@ func (b *BufferBase) BindLocked(rtpParameters webrtc.RTPParameters, codec webrtc
}
b.logger.Debugw("Setting feedback", "type", webrtc.TypeRTCPFBNACK)
b.nacker = nack.NewNACKQueue(nack.NackQueueParamsDefault)
if b.nacker == nil {
b.nacker = nack.NewNACKQueue(nack.NackQueueParamsDefault)
}
}
}