dandri/livekit
1
0
Fork 0
mirror of https://github.com/livekit/livekit.git synced 2026-03-30 22:05:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove warning for probe rate being too high. (#1970)

Browse Source 
Not super useful. It does happen a bunch of times especially at lower
end of estimate where the next layer up is high. We have to probe
anyway. Effects of large jumps have been mitigated by doing it for short
time.
This commit is contained in:
Raja Subramanian
2023-08-16 12:17:29 +05:30
committed by GitHub
parent 8b3deafbd4
commit c0ea1b9ced
1 changed files with 0 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
pkg/sfu/streamallocator/streamallocator.go
View File

@@ -1212,20 +1212,6 @@ func (s *StreamAllocator) newChannelObserverNonProbe() *ChannelObserver {
func (s *StreamAllocator) initProbe(probeGoalDeltaBps int64) {
expectedBandwidthUsage := s.getExpectedBandwidthUsage()
if float64(expectedBandwidthUsage) > 1.5*float64(s.committedChannelCapacity) {
// STREAM-ALLOCATOR-TODO-START
// Should probably skip probing if the expected usage is much higher than committed channel capacity.
// But, give that bandwidth estimate is volatile at times and can drop down to small values,
// not probing means streaming stuck in a well for long.
// Observe this and figure out if there is a threshold from practical use cases that can be used to
// skip probing safely
// STREAM-ALLOCATOR-TODO-END
s.params.Logger.Warnw(
"stream allocator: starting probe alarm",
fmt.Errorf("expected too high, expected: %d, committed: %d", expectedBandwidthUsage, s.committedChannelCapacity),
)
}
probeClusterId, probeGoalBps := s.probeController.InitProbe(probeGoalDeltaBps, expectedBandwidthUsage)
channelState := ""