dandri/simplex-chat
1
0 Fork 0
mirror of https://github.com/simplex-chat/simplex-chat.git synced 2026-10-22 10:12:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

plans: profile picker bottom bar: navigation bar sizes

Browse Source
This commit is contained in:
Narasimha-sc committed 2026-10-19 15:32:02 +00:00
1 parent 3f1eff2c3a
commit 0bae4332e4
1 file changed
+4 -4
Download Patch File Download Diff File Expand all files Collapse all files
plans/2026-09-05-profile-picker-bottom-bar.md
+4 -4
View File
@@ -22,9 +22,9 @@ Against that, the list's only bottom clearance is its trailing spacer:
| clearance in the list | `DEFAULT_BOTTOM_PADDING` 48.dp |
| `LazyColumnWithScrollBar` `contentPadding` | `0.dp` (default, not overridden) |
The shortfall is `8.dp` (more at larger app font scales) plus the navigation bar — commonly 32–56.dp, and the rows are
`DEFAULT_MIN_SECTION_ITEM_HEIGHT + 8 = 58.dp`, so on an Android phone drawing edge-to-edge with 3-button navigation nearly a whole row stays hidden; on desktop (no navigation bar) about 8.dp of it.
The navigation-bar part is inferred from the code: on Waydroid (3-button navigation) the app sees no navigation bar inset, and only about 8.dp was hidden there too.
The shortfall is `8.dp` (more at larger app font scales) plus the navigation bar — typically about 24.dp with gesture navigation and 48.dp with 3 buttons — and the rows are
`DEFAULT_MIN_SECTION_ITEM_HEIGHT + 8 = 58.dp`, so on an Android phone drawing edge-to-edge with 3-button navigation nearly the whole row stays hidden (all of it at larger app font scales); on desktop (no navigation bar) about 8.dp of it.
The navigation-bar part is inferred from the code: on Waydroid (3-button navigation) the app sees no navigation bar inset: the fix leaves about 48.dp above the bar there, the same as on desktop.
It only shows once the list nearly fills the screen; with few profiles nothing is hidden,
which is why it survived.
@@ -41,7 +41,7 @@ fully functional, so nothing draws attention to it.
#7329 adds an **"Add profile"** row at the end of this list. That moves a deliberately
sought affordance into the broken position: on a default Android install with enough
profiles to scroll, the button the feature exists for is partly hidden, and with 3-button navigation on a phone mostly or fully hidden (inferred, as above). On such phones the
profiles to scroll, the button the feature exists for is partly hidden, and with 3-button navigation on a phone nearly or fully hidden (inferred, as above). On such phones the
feature is hard or impossible to use without this fix, so #7329 should land after it.
Splitting it out anyway, because the defect is entirely pre-existing and worth fixing on