dandri/synapse
1
0
Fork 0
mirror of https://github.com/element-hq/synapse.git synced 2026-06-01 08:44:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add FIXME to remove USE_FROZEN_DICTS

Browse Source
This commit is contained in:
Erik Johnston
2026-05-29 12:09:32 +01:00
parent fbbdafb636
commit 08511cc830
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
synapse/events/__init__.py
+3 -7
View File
@@ -58,13 +58,9 @@ Whether we should use frozen_dict in FrozenEvent. Using frozen_dicts prevents
bugs where we accidentally share e.g. signature dicts. However, converting a
dict to frozen_dicts is expensive.
NOTE: This is overridden by the configuration by the Synapse worker apps, but
for the sake of tests, it is set here because it cannot be configured on the
homeserver object itself.
FIXME: Because of how this option works (changing the underlying types), it causes
subtle downstream bugs that makes type comparisons brittle, tracked by
https://github.com/element-hq/synapse/issues/18117
FIXME: This is no longer used as when we switched to using the Rust
implementation, all events are immutable already (and so don't benefit from
freezing).
"""