mirror of
https://github.com/element-hq/synapse.git
synced 2026-07-28 16:30:04 +00:00
Add some notes on missing tests for future readers
I changed things so deactivation did call these and no tests failed.
This commit is contained in:
@@ -261,6 +261,8 @@ class ProfileHandler:
|
||||
updates into rooms, which could cause rooms to be accidentally joined
|
||||
after the deactivated user has left them.
|
||||
|
||||
FIXME: This precondition seems to lack a test.
|
||||
|
||||
Args:
|
||||
target_user: the user whose displayname is to be changed.
|
||||
requester: The user attempting to make this change.
|
||||
@@ -385,6 +387,8 @@ class ProfileHandler:
|
||||
updates into rooms, which could cause rooms to be accidentally joined
|
||||
after the deactivated user has left them.
|
||||
|
||||
FIXME: This precondition seems to lack a test.
|
||||
|
||||
Args:
|
||||
target_user: the user whose avatar URL is to be changed.
|
||||
requester: The user attempting to make this change.
|
||||
@@ -829,6 +833,8 @@ class ProfileHandler:
|
||||
notify modules about the change whilst claiming it is not related
|
||||
to user deactivation.
|
||||
|
||||
FIXME: This precondition seems to lack a test.
|
||||
|
||||
Args:
|
||||
target_user: the user whose profile is to be changed.
|
||||
requester: The user attempting to make this change.
|
||||
@@ -914,6 +920,8 @@ class ProfileHandler:
|
||||
notify modules about the change whilst claiming it is not related
|
||||
to user deactivation.
|
||||
|
||||
FIXME: This precondition seems to lack a test.
|
||||
|
||||
Args:
|
||||
target_user: the user whose profile is to be changed.
|
||||
requester: The user attempting to make this change.
|
||||
|
||||
Reference in New Issue
Block a user